-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing Issues with CrossPlane Integrations. #20
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. The change to the ArgoCD spec looks good. I am not sure if I want to add RDS compositions though. Looks like this was taken from the crossplane on eks repo. I would rather not duplicate things here.
Also I don't think I want to add RDS without proper support for it in Backstage.
thanks @elamaran11 for this. I agree with Manabu on the compositions. Looks like we would want to take the crossplane compositions under https://github.com/cnoe-io/backstage-crossplane-integrations and couple them with the corresponding Backstage templates, similar to what we have done for Terraform. wdyt? |
@nimakaviani @nabuskey As part of Manabu's concern i already have this PR in backstage-crossplane-integrations repo to add Backstage support for RDS. His second concern was duplicating from
Overall the end result is same but we arent really achieving a lot with this approach vs doing a lot of moving of stuff here and there. Please let me know WY both think, i can find time next week to work on this. |
Thanks @elamaran11 ... I agree with your point about also moving the s3 compositions and the related backstage templates over to the backstage-crossplane-integrations repo. We initially didn't do it because that repo did not exist and also we dont have proper instructions on the website on how to get the stuff to work together. Lets work on consolidating everything under backstage-crossplane-integrations |
Signed-off-by: Elamaran Shanmugam <[email protected]>
@nimakaviani Thankyou for agreeing to my approach. I will work on another PR to stacks repo and crossplane integrations repo to consolidate crossplane compositions. @nimakaviani @nabuskey Please merge this PR which has bug fix to fix a show stopper with crossplane integrations because crossplane currently fails without this fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR Does the following :